Rector Output upgrading to PHP 8.2.16

[flintnapa]

In terminal run: vendor/bin/rector process --dry-run after installing: https://getrector.com/documentation
Only 20 files appeared that needed upgrading based on Applied rules:
* AddVoidReturnTypeWhereNoReturnRector

These are:
1) includes/packages/ckeditor/ckeditor_php5.php:267
2) includes/packages/recaptcha/ReCaptcha/RequestMethod/Curl.php:66
3) includes/template/Template.php:111
4) includes/template/TemplateCompile.php:54
5) includes/User.php:91
6) includes/auction/Auction.php:49
7) includes/class_email_handler.php:22
8) includes/class_fees.php:51
9) includes/database/DatabasePDO.php:40
10) includes/diff/diff.php:27
11) includes/diff/engine.php:332
12) includes/diff/renderer.php:34
13) includes/functions_global.php:54
14) includes/packages/PHPMailer/class.phpmailer.php:714
15) includes/packages/PHPMailer/class.pop3.php:292
16) includes/packages/PHPMailer/class.smtp.php:585
17) includes/packages/PluploadHandler.php:193
18) includes/packages/captcha/securimage.php:1102
19) includes/packages/captchao/securimage.php:1102
20) includes/packages/ckeditor/ckeditor_php4.php:96

An example of what Rector wants to do:

Code:

@@ @@
*
*  @param $basePath (string) URL to the %CKEditor installation directory (optional).
*/
- function CKEditor($basePath = null) {
+ function CKEditor($basePath = null): void {
if (!empty($basePath)) {
$this->basePath = $basePath;
}

Rector makes these changes and you get the white screen of death.

In any event, the script Webid 1.2.1 runs fine, as is, with only 20 files needing to be modified.

Perhaps someone else can explain why making the above Php8 changes caused the script to break.


https://webidsupport.4up.eu/forums/showt...hp?tid=100